Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comments #58

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Support comments #58

merged 4 commits into from
Oct 30, 2023

Conversation

k-bx
Copy link
Contributor

@k-bx k-bx commented Oct 27, 2023

Also: improve error reporting

@k-bx
Support comments
d7ce75a 
Also: improve error reporting
pjsier
pjsier requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@pjsier pjsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks great other than the clippy and rustfmt errors. Those look like quick fixes so I can go ahead and approve and merge once those are passing

@k-bx k-bx requested a review from pjsier October 29, 2023 16:08
@pjsier
Copy link
Member

pjsier commented Oct 29, 2023

Looks like there's a test still failing, not sure if it was caused by fixing a clippy lint that was a false positive?

@k-bx
Copy link
Contributor Author

k-bx commented Oct 30, 2023

Looks like there's a test still failing, not sure if it was caused by fixing a clippy lint that was a false positive?

My bad, should be fixed now.

pjsier
pjsier approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@pjsier pjsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those updates, looks great!

@pjsier pjsier merged commit 77d647d into georust:main Oct 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjsier pjsier pjsier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-bx @pjsier